[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/altera/IdDependentBackwardBranchCheck.h:32
+        : VariableDeclaration(Declaration), Location(Location),
+          Message(Message) {}
+    IdDependencyRecord(const FieldDecl *Declaration, SourceLocation Location,
----------------
aaron.ballman wrote:
> 
Ah, it looks like some changes conflicted with my suggestion -- when the function was taking a std::string, the move was needed, but now with a Twine, the move is an issue. You should remove the std::move.


================
Comment at: clang-tools-extra/clang-tidy/altera/IdDependentBackwardBranchCheck.h:35
+                       std::string Message)
+        : FieldDeclaration(Declaration), Location(Location), Message(Message) {}
+    IdDependencyRecord() = default;
----------------
aaron.ballman wrote:
> 
Same here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70094/new/

https://reviews.llvm.org/D70094