[PATCH] D101696: [Matrix] Implement C-style explicit type conversions in CXX for matrix types

Mon May 3 05:07:41 PDT 2021

SaurabhJha added a comment.

In D101696#2732983 <https://reviews.llvm.org/D101696#2732983>, @fhahn wrote:

> Thanks for the update! Technically the fix in `clang/lib/CodeGen/CGExprScalar.cpp` is unrelated to C++ support. It would be great if you could put up a separate patch, so we can land this independently.
>
> The whole patch basically LGTM. It would be great if you could add a test casting from unsigned to float/double (looks like no test generates `uitofp`) and a test for casting between signed & unsigned integers of the same size (unless there are already tests for that I missed)

Sure thing. I have created a new patch here https://reviews.llvm.org/D101754. Once that's merged, I will rebase this one with the new main.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101696/new/

https://reviews.llvm.org/D101696