[PATCH] D101516: Introduce clangd-server-monitor tool

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/test/remote-index/pipeline_helper.py:77
+  index_server_monitor_process.wait()
+  for line in index_server_monitor_process.stderr:
+    args.server_log.write(line)
----------------
logs for index-server and monitor gets intertwined (as we put logs from index-server until `initialization` above). so can we output monitoring logs after we've dumped all the logs from index-server?


================
Comment at: clang-tools-extra/clangd/test/remote-index/pipeline_helper.py:98
 
+  monitor_info = index_server_monitor_process.stdout.read()
+  if not monitor_info:
----------------
can we just dump the stdout to main process (as we do with other subprocesses) and check for the output in the lit tests instead? that way we can check for particular values without complicating the helper instead


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101516/new/

https://reviews.llvm.org/D101516