[PATCH] D101275: [clangd] Hide inlay hints capability behind a command-line flag
Nathan Ridge via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun May 2 22:02:23 PDT 2021
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGcea736e5b8a4: [clangd] Hide inlay hints capability behind a command-line flag (authored by nridge).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101275/new/
https://reviews.llvm.org/D101275
Files:
clang-tools-extra/clangd/ClangdLSPServer.cpp
clang-tools-extra/clangd/ClangdLSPServer.h
clang-tools-extra/clangd/tool/ClangdMain.cpp
Index: clang-tools-extra/clangd/tool/ClangdMain.cpp
===================================================================
--- clang-tools-extra/clangd/tool/ClangdMain.cpp
+++ clang-tools-extra/clangd/tool/ClangdMain.cpp
@@ -308,6 +308,9 @@
Hidden,
};
+opt<bool> InlayHints{"inlay-hints", cat(Features),
+ desc("Enable preview of InlayHints feature"), init(false)};
+
opt<unsigned> WorkerThreadsCount{
"j",
cat(Misc),
@@ -829,6 +832,7 @@
}
Opts.AsyncThreadsCount = WorkerThreadsCount;
Opts.FoldingRanges = FoldingRanges;
+ Opts.InlayHints = InlayHints;
Opts.MemoryCleanup = getMemoryCleanupFunction();
Opts.CodeComplete.IncludeIneligibleResults = IncludeIneligibleResults;
Index: clang-tools-extra/clangd/ClangdLSPServer.h
===================================================================
--- clang-tools-extra/clangd/ClangdLSPServer.h
+++ clang-tools-extra/clangd/ClangdLSPServer.h
@@ -62,6 +62,9 @@
std::function<bool(const Tweak &)> TweakFilter = [](const Tweak &T) {
return !T.hidden(); // only enable non-hidden tweaks.
};
+
+ /// Enable preview of InlayHints feature.
+ bool InlayHints = false;
};
ClangdLSPServer(Transport &Transp, const ThreadsafeFS &TFS,
Index: clang-tools-extra/clangd/ClangdLSPServer.cpp
===================================================================
--- clang-tools-extra/clangd/ClangdLSPServer.cpp
+++ clang-tools-extra/clangd/ClangdLSPServer.cpp
@@ -571,7 +571,6 @@
{"referencesProvider", true},
{"astProvider", true}, // clangd extension
{"typeHierarchyProvider", true},
- {"clangdInlayHintsProvider", true},
{"memoryUsageProvider", true}, // clangd extension
{"compilationDatabase", // clangd extension
llvm::json::Object{{"automaticReload", true}}},
@@ -608,6 +607,9 @@
if (Opts.FoldingRanges)
ServerCaps["foldingRangeProvider"] = true;
+ if (Opts.InlayHints)
+ ServerCaps["clangdInlayHintsProvider"] = true;
+
std::vector<llvm::StringRef> Commands;
for (llvm::StringRef Command : Handlers.CommandHandlers.keys())
Commands.push_back(Command);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101275.342311.patch
Type: text/x-patch
Size: 2149 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210503/49224254/attachment-0001.bin>
More information about the cfe-commits
mailing list