[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

[Frank Derry Wanye via Phabricator via cfe-commits]

ffrankies updated this revision to Diff 342278.
ffrankies added a comment.

Addressed comments by @aaron.ballman

- Changed capitalization in enum
- Used `std::move` in `IdDependencyRecord` constructors
- Initialized `VariableDeclaration` and `FieldDeclaration` to `nullptr`
- Used `isAssignmentOperator()` instead of listing the assingment operators in the matchers
- Simplified code around if statement expressions
- Switched to `llvm::Twine` and `llvm::raw_string_ostream` when constructing warning and note messages
- Changed `getLoopType()` body to a switch statement instead of a series of if-else statements


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70094/new/

https://reviews.llvm.org/D70094

Files:
  clang-tools-extra/clang-tidy/altera/AlteraTidyModule.cpp
  clang-tools-extra/clang-tidy/altera/CMakeLists.txt
  clang-tools-extra/clang-tidy/altera/IdDependentBackwardBranchCheck.cpp
  clang-tools-extra/clang-tidy/altera/IdDependentBackwardBranchCheck.h
  clang-tools-extra/docs/ReleaseNotes.rst
  clang-tools-extra/docs/clang-tidy/checks/altera-id-dependent-backward-branch.rst
  clang-tools-extra/docs/clang-tidy/checks/list.rst
  clang-tools-extra/test/clang-tidy/checkers/altera-id-dependent-backward-branch.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70094.342278.patch
Type: text/x-patch
Size: 24612 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210502/0f242788/attachment-0001.bin>