[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

Harald van Dijk via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun May 2 10:14:24 PDT 2021


hvdijk added a comment.

In D63423#2732186 <https://reviews.llvm.org/D63423#2732186>, @xbolva00 wrote:

> I remember that was interest to support macros too :) tbh I cant remember now such real world case where “macro ^ cst” was an issue but.. it was a long time ago ;)
>
> If you are want, you can send patch to to avoid warning in this case, we can discuss it.

Will do; the change is trivial after D97445 <https://reviews.llvm.org/D97445>: it's just changing that to use `||` rather than `&&`. I'll do that and update the tests to match. I don't know whether that'll be what we want, but it may be easier to talk about once we have a good picture from the test case update what it affects.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63423/new/

https://reviews.llvm.org/D63423



More information about the cfe-commits mailing list