[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat May 1 13:57:41 PDT 2021


MaskRay added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:218
+def err_drv_invalid_value_with_suggestion : Error<
+    "invalid value '%1' in '%0', valid values to '%0' are: %2">;
 def err_drv_invalid_remap_file : Error<
----------------
Note %0 is duplicated in ` valid values to '%0'` - elsewhere we use `, expected ...` 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101387/new/

https://reviews.llvm.org/D101387



More information about the cfe-commits mailing list