[PATCH] D101684: [WebAssembly] Add end-to-end codegen tests for wasm_simd128.h

Thomas Lively via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 30 22:37:16 PDT 2021


tlively created this revision.
tlively added reviewers: aheejin, dschuff.
Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100.
tlively requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.

Add tests checking that each SIMD intrinsic produces the expected instruction.
Assembly tests are generally discouraged in clang, but in this case we actually
care about the specific instruction being generated from the intrinsics. There
are nine problems with the current intrinsic codegen and they are marked in the
tests with FIXMEs.

Also fix the names of a few instructions to match the spec, fix the ordering of
*_const intrinsics, and add the missing wasm_i64x2_make intrinsic.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D101684

Files:
  clang/lib/Headers/wasm_simd128.h
  clang/test/Headers/wasm.c
  llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td
  llvm/test/CodeGen/WebAssembly/simd-intrinsics.ll
  llvm/test/MC/WebAssembly/simd-encodings.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101684.342120.patch
Type: text/x-patch
Size: 74412 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210501/5447c32d/attachment-0001.bin>


More information about the cfe-commits mailing list