[PATCH] D99741: [RISCV][Clang] Add some RVV Floating-Point intrinsic functions. (vfclass, vfmerge, vfrec7, vfrsqrt7, vfsqrt)

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 30 18:22:40 PDT 2021


thakis added a subscriber: rnk.
thakis added a comment.

> ! In D99741#2721669 <https://reviews.llvm.org/D99741#2721669>, @craig.topper wrote:
>  We're preparing a patch to remove to stop testing both rv32 and rv64 on every test. That should reduce the time by half. What is an acceptable number?

You tell me. I'd say well below 1%?

I wanted to prepare a graph that shows check-clang time over the last year – it stayed basically constant and the jumped by 20% (now 10% now that half the tests are disabled). It'd look dramatic, but I haven't had time to make a graph. I'm sure you can imagine it though :) (Also, I feel the burden of proof shouldn't be on people pointing out regressions.)

@rnk suggested putting these tests behind some kind of `REQUIRES: expensive-checks` thing that's off by default, instead of reverting everything, until perf is sorted out. That sounds like a great idea to me – wdyt?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99741/new/

https://reviews.llvm.org/D99741



More information about the cfe-commits mailing list