[PATCH] D101654: [HIP] Fix device lib selection

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked 2 inline comments as done.
yaxunl added inline comments.


================
Comment at: clang/test/Driver/hip-device-libs.hip:165
+// FAST: "-mlink-builtin-bitcode" "{{.*}}oclc_daz_opt_off.bc"
+// FAST-SAME: "-mlink-builtin-bitcode" "{{.*}}oclc_unsafe_math_on.bc"
+// FAST-SAME: "-mlink-builtin-bitcode" "{{.*}}oclc_finite_only_on.bc"
----------------
MaskRay wrote:
> yaxunl wrote:
> > MaskRay wrote:
> > > You can use the `-SAME: {{^}} ` pattern in linux-cross.cpp
> > What does `{{^}}` do? Thanks.
> `// CHECK-SAME: {{^}} "-mlink...` ensures that the unmatched part after the previous pattern must start with ` "-mlink...`
> 
> In case there is a new option, the pattern can catch such a case.
I see. Actually we do not need to make sure that. We only need to make sure these items exist in the same line. We do not even care about their orders.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101654/new/

https://reviews.llvm.org/D101654