[PATCH] D101671: Modules: Remove an extra early return, NFC

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 30 15:17:49 PDT 2021


dexonsmith created this revision.
dexonsmith added reviewers: jansvoboda11, Bigcheese.
dexonsmith requested review of this revision.
Herald added a project: clang.

Remove an early return from an `else` block that's immediately followed
by an equivalent early return after the `else` block.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D101671

Files:
  clang/lib/Frontend/CompilerInstance.cpp


Index: clang/lib/Frontend/CompilerInstance.cpp
===================================================================
--- clang/lib/Frontend/CompilerInstance.cpp
+++ clang/lib/Frontend/CompilerInstance.cpp
@@ -1885,8 +1885,6 @@
       return Result;
     Module = Result;
     MM.cacheModuleLoad(*Path[0].first, Module);
-    if (!Module)
-      return Module;
   }
 
   // If we never found the module, fail.  Otherwise, verify the module and link


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101671.342063.patch
Type: text/x-patch
Size: 446 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210430/b6a96619/attachment.bin>


More information about the cfe-commits mailing list