[PATCH] D101654: [HIP] Fix device lib selection

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl marked 2 inline comments as done.
yaxunl added inline comments.


================
Comment at: clang/test/Driver/hip-device-libs.hip:117
+// Test -fast-math
+// RUN: %clang -### -target x86_64-linux-gnu \
+// RUN:   --cuda-gpu-arch=gfx900 \
----------------
MaskRay wrote:
> You can pack more arguments on one line.
> 
> Fewer line wraps actually make a test more readable IMO.
Will do.


================
Comment at: clang/test/Driver/hip-device-libs.hip:165
+// FAST: "-mlink-builtin-bitcode" "{{.*}}oclc_daz_opt_off.bc"
+// FAST-SAME: "-mlink-builtin-bitcode" "{{.*}}oclc_unsafe_math_on.bc"
+// FAST-SAME: "-mlink-builtin-bitcode" "{{.*}}oclc_finite_only_on.bc"
----------------
MaskRay wrote:
> You can use the `-SAME: {{^}} ` pattern in linux-cross.cpp
What does `{{^}}` do? Thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101654/new/

https://reviews.llvm.org/D101654