[PATCH] D101387: [Clang] remove text extension from diag::err_drv_invalid_value_with_suggestion
Dávid Bolvanský via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 30 13:05:56 PDT 2021
xbolva00 added inline comments.
================
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:280
+def err_drv_small_columns : Error<
+ "invalid value '%1' in '%0', expected '%1' to be '%2' or greater">;
----------------
nickdesaulniers wrote:
> xbolva00 wrote:
> > nickdesaulniers wrote:
> > > xbolva00 wrote:
> > > > nickdesaulniers wrote:
> > > > > xbolva00 wrote:
> > > > > > invalid value '%1' in '%0', value must be '%2' or greater
> > > > > >
> > > > > > ?
> > > > > >
> > > > > > Current wording sounds strange imho.
> > > > > I don't care what color we paint the bikeshed, but please suggest a color if you don't like the one I've chosen.
> > > > ?
> > > >
> > > > I suggested.
> > > I'm sorry; I don't know how I misread what you said.
> > No problem, thanks :)
> Does the updated patch look good?
Yeah!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101387/new/
https://reviews.llvm.org/D101387
More information about the cfe-commits
mailing list