[PATCH] D100801: Thread safety analysis: Replace flags in FactEntry by SourceKind [NFC]
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 30 05:55:56 PDT 2021
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a formatting nit. Thanks, this is more clear than a set of booleans.
================
Comment at: clang/lib/Analysis/ThreadSafety.cpp:138
+ bool declared() const { return Source == Declared; }
+ bool managed() const { return Source == Managed; }
----------------
Might as well fix the clang-tidy diagnostic (we don't usually try to line up function qualifiers like that).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100801/new/
https://reviews.llvm.org/D100801
More information about the cfe-commits
mailing list