[PATCH] D101516: Introduce clangd-server-monitor tool

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

thanks for doing this! can we also have a lit test? we already have some tests spinning up an index-server, i suppose we can make an extra rpc to those and ensure we get a success response?



================
Comment at: clang-tools-extra/clangd/index/remote/monitor/CMakeLists.txt:4
+  )
+add_clang_executable(clangd-server-monitor
+  Monitor.cpp
----------------
s/server/index-server/

being more specific would be nice, just in case we have more servers (i.e. review) in the future.


================
Comment at: clang-tools-extra/clangd/index/remote/monitor/Monitor.cpp:54
+  if (!Status.ok()) {
+    llvm::errs() << llvm::formatv(
+        "Can not request monitoring information ({0}): {1}\n",
----------------
nit: elog


================
Comment at: clang-tools-extra/clangd/index/remote/monitor/Monitor.cpp:59
+  }
+  llvm::outs() << Response.DebugString();
+}
----------------
rather than dumping protobuf, can we dump in json ? see https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.util.json_util


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101516/new/

https://reviews.llvm.org/D101516