[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

Thu Apr 29 23:09:47 PDT 2021

ChuanqiXu added a comment.

In D97915#2727787 <https://reviews.llvm.org/D97915#2727787>, @ychen wrote:

> In D97915#2727759 <https://reviews.llvm.org/D97915#2727759>, @ChuanqiXu wrote:
>
>> May I ask a question may be too simple? What if the user specify the alignment for promise (or any other local variables) to 128 or even 256? Since it looks like all the discuss before assumes that the largest alignment requirement is 64.
>
> 64 is one example. Bitwise operations (`coro.alloc.align` block in the attached example) should handle all valid alignment numbers.

Thanks for the example. And I recommended to add comment for the corresponding code. The code for bit-operation and the example confused me. I would look into this and the other part later.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97915/new/

https://reviews.llvm.org/D97915