[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

Dávid Bolvanský via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 29 17:14:41 PDT 2021


xbolva00 added a comment.

In D100581#2727460 <https://reviews.llvm.org/D100581#2727460>, @aeubanks wrote:

> regarding adding these to a warning group in a separate change, it's easier to revert a smaller second change that adds this to warning groups, and easier to iterate upon in tree when there are discovered issues
> it's not dead code if it has tests

I meant dead code in terms of users. You can always commit this patch as two - first with new warning, second - add to groups.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100581/new/

https://reviews.llvm.org/D100581



More information about the cfe-commits mailing list