[PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo

[Shafik Yaghmour via Phabricator via cfe-commits]

shafik added inline comments.


================
Comment at: clang/lib/Parse/ParseStmtAsm.cpp:589
+      TheTarget->createMCObjectFileInfo(
+          /*PIC*/ false, Ctx));
+  Ctx.setObjectFileInfo(MOFI.get());
----------------
`/*PIC=*/false`


================
Comment at: llvm/tools/llvm-mca/llvm-mca.cpp:381
+  std::unique_ptr<MCObjectFileInfo> MOFI(TheTarget->createMCObjectFileInfo(
+      /* PIC= */ false, Ctx));
+  Ctx.setObjectFileInfo(MOFI.get());
----------------
`/*PIC=*/ false` 

see clang-tidy rule that checks for this format: https://clang.llvm.org/extra/clang-tidy/checks/bugprone-argument-comment.html


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101462/new/

https://reviews.llvm.org/D101462