[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

Thu Apr 29 12:41:57 PDT 2021

leonardchan added a comment.

In D99381#2723563 <https://reviews.llvm.org/D99381#2723563>, @vitalybuka wrote:

> In D99381#2721619 <https://reviews.llvm.org/D99381#2721619>, @phosek wrote:
>
>> What I think @vitalybuka meant is keeping `sanitizer_platform_limits_fuchsia.h` as you had it, but including it unconditionally. Since the entire file is wrapped in `#if SANITIZER_FUCHSIA ... #endif`, the inclusion would be a no-op on platforms other than Fuchsia so no need to wrap the `#include` in `#if SANITIZER_FUCHSIA` as well.
>
> Correct., Just:
>
>   #include "sanitizer_common/sanitizer_platform_limits_fuchsia.h"
>   #include "sanitizer_common/sanitizer_platform_limits_posix.h"

I see. Thanks for the clarifications.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99381/new/

https://reviews.llvm.org/D99381