[PATCH] D101479: [Driver] Support libc++ in MSVC

[Reid Kleckner via Phabricator via cfe-commits]

rnk added a comment.

The test doesn't seem to pass on Jenkins. Maybe we need a REQUIRES line or a fake sysroot or something for the test.



================
Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:1332
+
+  auto AddLibcxxIncludePath = [&](StringRef Path) {
+    std::string Version = detectLibcxxVersion(Path);
----------------
I'm guessing this is copy-pasted code from the other toolchains, but this lambda makes less sense when its only called once. If you inline it, we don't need an extra SmallString or lambda.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101479/new/

https://reviews.llvm.org/D101479