[PATCH] D101491: [ASan] Rename `-fsanitize-address-destructor-kind=` to drop the `-kind` suffix.

Thu Apr 29 11:02:31 PDT 2021

delcypher added a comment.

In D101491#2725348 <https://reviews.llvm.org/D101491#2725348>, @jansvoboda11 wrote:

> In D101491#2724025 <https://reviews.llvm.org/D101491#2724025>, @delcypher wrote:
>
>> @jansvoboda11 Should I use the the alias feature so that the old `-fsanitize-address-destructor-kind` argument is still parsed? I'm not sure if it's worth it but if doing so is very simple and has a low maintenance burden we should probably do it.
>
> I'm fine with omitting the alias if the original flag didn't make it into a release and it's unlikely that downstream TOT users are using it.

The change that landed this flag originally (5d64dd8e3c22e12e4f7b3d08ffe88fc41e727117 <https://reviews.llvm.org/rG5d64dd8e3c22e12e4f7b3d08ffe88fc41e727117>) doesn't seem to be in the `release/12.x` branch. It also wasn't cherry picked to the downstream Apple branches on GitHub. I can't be sure about other downstream users of LLVM but I do think it's very unlikely that anyone adopted this flag.

I don't mind adding an alias but I'd need a little guidance on how to do it correctly and also where to add code to emit a warning about the old flag being deprecated.

================
Comment at: clang/docs/ClangCommandLineReference.rst:873

-.. option:: -fsanitize-address-destructor-kind=<arg>
+.. option:: -fsanitize-address-destructor=<arg>

----------------
vitalybuka wrote:
> <arc> here is inconsistent with MetaVarName<"<kind>"
I'll fix that now.

================
Comment at: clang/include/clang/Driver/Options.td:1542
   Group<f_clang_Group>;
 def sanitize_address_destructor_kind_EQ
+    : Joined<["-"], "fsanitize-address-destructor=">,
----------------
jansvoboda11 wrote:
> Nit: remove `_kind` from the def name.
Good catch. I'll fix that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101491/new/

https://reviews.llvm.org/D101491