[PATCH] D99599: [NewPM] Add an option to dump pass structure

[Haowei Wu via Phabricator via cfe-commits]

haowei added a comment.

We are seeing test failures in our builders with message after your patch. Could you take a look and fix this unit test please?

  FAIL: Clang :: Driver/debug-pass-structure.c (6773 of 27894)
  ******************** TEST 'Clang :: Driver/debug-pass-structure.c' FAILED ********************
  Script:
  --
  : 'RUN: at line 2';   /opt/s/w/ir/x/w/staging/llvm_build/bin/clang -fexperimental-new-pass-manager -fdebug-pass-structure -O3 -S -emit-llvm /opt/s/w/ir/x/w/llvm-project/clang/test/Driver/debug-pass-structure.c -o /dev/null 2>&1 | /opt/s/w/ir/x/w/staging/llvm_build/bin/FileCheck /opt/s/w/ir/x/w/llvm-project/clang/test/Driver/debug-pass-structure.c --check-prefix=NEWPM
  : 'RUN: at line 3';   /opt/s/w/ir/x/w/staging/llvm_build/bin/clang -flegacy-pass-manager -fdebug-pass-structure -O0 -S -emit-llvm /opt/s/w/ir/x/w/llvm-project/clang/test/Driver/debug-pass-structure.c -o /dev/null 2>&1 | /opt/s/w/ir/x/w/staging/llvm_build/bin/FileCheck /opt/s/w/ir/x/w/llvm-project/clang/test/Driver/debug-pass-structure.c --check-prefix=LEGACYPM
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /opt/s/w/ir/x/w/llvm-project/clang/test/Driver/debug-pass-structure.c:46:19: error: LEGACYPM-NEXT: expected string not found in input
  // LEGACYPM-NEXT: Pass Arguments: -tti -targetlibinfo -assumption-cache-tracker -profile-summary-info -annotation2metadata -forceattrs -basiccg -always-inline -annotation-remarks
                    ^
  <stdin>:5:17: note: scanning from here
   Module Verifier
                  ^
  <stdin>:6:1: note: possible intended match here
  Pass Arguments: -tti -targetlibinfo -assumption-cache-tracker -profile-summary-info -annotation2metadata -forceattrs -basiccg -always-inline -barrier -annotation-remarks
  ^
  
  Input file: <stdin>
  Check file: /opt/s/w/ir/x/w/llvm-project/clang/test/Driver/debug-pass-structure.c
  
  -dump-input=help explains the following input dump.
  
  Input was:
  <<<<<<
             1: Pass Arguments: -tti -targetlibinfo -verify 
             2: Target Transform Information 
             3: Target Library Information 
             4:  FunctionPass Manager 
             5:  Module Verifier 
  next:46'0                     X error: no match found
             6: Pass Arguments: -tti -targetlibinfo -assumption-cache-tracker -profile-summary-info -annotation2metadata -forceattrs -basiccg -always-inline -barrier -annotation-remarks 
  next:46'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  next:46'1     ?                                                                                                                                                                          possible intended match
             7: Target Transform Information 
  next:46'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
             8: Target Library Information 
  next:46'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~
             9: Assumption Cache Tracker 
  next:46'0     ~~~~~~~~~~~~~~~~~~~~~~~~~
            10: Profile summary info 
  next:46'0     ~~~~~~~~~~~~~~~~~~~~~
            11:  ModulePass Manager 
  next:46'0     ~~~~~~~~~~~~~~~~~~~~
             .
             .
             .
  >>>>>>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99599/new/

https://reviews.llvm.org/D99599