[PATCH] D101462: Make it possible for targets to define their own MCObjectFileInfo
Fangrui Song via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 29 09:22:58 PDT 2021
MaskRay added a comment.
The `InitMCObjectFileInfo` refactoring is good, but I'll suggest `initMCObjectFileInfo(MCContext &ctx, bool PIC, bool LargeCodeModel)` (change the function name to `lowerCase`, and reorder MCContext before bool arguments).
The refactoring adding `Triple` to MCContext::MCContext should be separate. We sill want to see whether that is good.
The RISC-V functionality change should be separate as well.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101462/new/
https://reviews.llvm.org/D101462
More information about the cfe-commits
mailing list