[PATCH] D101168: [C++4OpenCL] Add clang extension for non-portable kernel parameters

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia added inline comments.


================
Comment at: clang/docs/LanguageExtensions.rst:1808
+With this extension it is possible to enable the use of some restricted types in kernel parameters.
+The restrictions can be relaxed using regular OpenCL extension pragma mechanism
+detailed in `the OpenCL Extension Specification, section 1.2
----------------
Let's add references to relevant OpenCL C and C++ for OpenCL sections with restrictions.


================
Comment at: clang/docs/LanguageExtensions.rst:1818
+.. code-block:: c++
+  // Is POD because it is Plain Old Data
+  struct Pod {
----------------



================
Comment at: clang/docs/LanguageExtensions.rst:1824
+
+  // Not POD because of the constructor
+  // Is standard layout because there is only one access control
----------------



================
Comment at: clang/docs/LanguageExtensions.rst:1824
+
+  // Not POD because of the constructor
+  // Is standard layout because there is only one access control
----------------
Anastasia wrote:
> 
Let's add `.` at the end of every sentance. :)


================
Comment at: clang/docs/LanguageExtensions.rst:1825
+  // Not POD because of the constructor
+  // Is standard layout because there is only one access control
+  struct OnlySL {
----------------



================
Comment at: clang/docs/LanguageExtensions.rst:1832
+
+  // Not standard layout because of two different access control
+  struct NotSL {
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101168/new/

https://reviews.llvm.org/D101168