[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 28 12:56:17 PDT 2021


lebedev.ri added a comment.

In D100581#2723709 <https://reviews.llvm.org/D100581#2723709>, @aeubanks wrote:

> reverted
> regarding having a reviewer who is knowledgable in clang diagnostics, I assumed that george.burgess.iv was knowledgable and was happy with the change after his comments, perhaps I should have waited for an explicit LGTM

It's fine, there are always bugs everywhere, won't all be caught.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100581/new/

https://reviews.llvm.org/D100581



More information about the cfe-commits mailing list