[PATCH] D101426: [RISCV] Update subset naming convertion for the latest spec

[Zakk Chen via Phabricator via cfe-commits]

khchen added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:180
+  // as described in RISC-V User-Level ISA 20191213.
   SmallVector<StringRef, 8> Split;
   Exts.split(Split, StringRef("_"));
----------------
If we want to update the arch string rules to ISA 20191213, should we also need to handle `Zicsr`, `Zifencei`, `Zam` and `Ztso`?


================
Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:294
   // The canonical order specified in ISA manual.
   // Ref: Table 22.1 in RISC-V User-Level ISA V2.2
   StringRef StdExts = "mafdqlcbjtpvn";
----------------
nit: Table 27.1 in RISC-V User-Level ISA 20191213


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101426/new/

https://reviews.llvm.org/D101426