[PATCH] D101275: [clangd] Hide inlay hints capability behind a command-line flag

Wed Apr 28 01:21:15 PDT 2021

sammccall added inline comments.

================
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:312
+                     desc("Enable preview of InlayHints feature"), init(false),
+                     Hidden};
+
----------------
njames93 wrote:
> Does it make sense to hide this flag? This is a feature that's basically in a shippable state disregarding any LSP standardization.
We may or may not *want* to ship it without further standardization, it can make maintenance more complicated.

But I agree if it's behind a flag it doesn't necessarily need to be hidden, esp if we plan to make a call closer to the release cut.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101275/new/

https://reviews.llvm.org/D101275