[PATCH] D101259: [clang-tidy] Fix cppcoreguidelines-pro-type-vararg false positives with __builtin_ms_va_list

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 27 23:32:07 PDT 2021


njames93 added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:84
+  // In these cases we need to remove all typedefs one by one to check this.
+  const auto VaListKind = Context.getTargetInfo().getBuiltinVaListKind();
+  using BuiltinVaListKind = TargetInfo::BuiltinVaListKind;
----------------
We typically avoid cost qualification on local variables and as the type isn't spelled in the initializer, can you replace auto with the actual deduced type. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101259/new/

https://reviews.llvm.org/D101259



More information about the cfe-commits mailing list