[PATCH] D99350: [OPENMP]Fix PR49649: The introduction of $ref globals is not always valid.

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert added a comment.

The cast was never the problem but the fact that the `$ref` lives in the global address space while the global value might be in the shared one.
D101030 <https://reviews.llvm.org/D101030> gives a way out here by not creating `$ref` variables if there is no host version of a global. This makes sense because we don't need to copy to the global ever.
So, users can have static globals in shared memory by ensuring they are not host accessible. We probably should emit an error if they try to do global in shared memory
that has a host version.

Long story short, this cast won't help.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99350/new/

https://reviews.llvm.org/D99350