[PATCH] D101365: [clang-query] Add check to prevent setting srcloc when no introspection is available.

Stephen Kelly via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 27 14:46:29 PDT 2021


steveire accepted this revision.
steveire added a comment.
This revision is now accepted and ready to land.

LGTM!



================
Comment at: clang-tools-extra/unittests/clang-query/QueryParserTest.cpp:249
+  EXPECT_EQ("dump ", Comps[3 + static_cast<int>(HasIntrospection)].TypedText);
+  EXPECT_EQ("dump", Comps[3 + static_cast<int>(HasIntrospection)].DisplayText);
 
----------------
nit: I think `HasIntrospection ? 4 : 3` would be clearer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101365/new/

https://reviews.llvm.org/D101365



More information about the cfe-commits mailing list