[clang] bf9eef9 - Gnu: Replace with a GCCInstallation.isValid() check with assert

[Fangrui Song via cfe-commits]

Author: Fangrui Song
Date: 2021-04-27T13:31:37-07:00
New Revision: bf9eef92b6cd71d262ac12ce6c4919271bd6c910

URL: https://github.com/llvm/llvm-project/commit/bf9eef92b6cd71d262ac12ce6c4919271bd6c910
DIFF: https://github.com/llvm/llvm-project/commit/bf9eef92b6cd71d262ac12ce6c4919271bd6c910.diff

LOG: Gnu: Replace with a GCCInstallation.isValid() check with assert

Added: 
    

Modified: 
    clang/lib/Driver/ToolChains/Gnu.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Driver/ToolChains/Gnu.cpp b/clang/lib/Driver/ToolChains/Gnu.cpp
index e2cec7c333c0..53bba72dc270 100644
--- a/clang/lib/Driver/ToolChains/Gnu.cpp
+++ b/clang/lib/Driver/ToolChains/Gnu.cpp
@@ -2964,9 +2964,7 @@ bool Generic_GCC::addLibStdCXXIncludePaths(Twine IncludeDir, StringRef Triple,
 bool Generic_GCC::addGCCLibStdCxxIncludePaths(
     const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args,
     StringRef DebianMultiarch) const {
-  // Use GCCInstallation to know where libstdc++ headers are installed.
-  if (!GCCInstallation.isValid())
-    return false;
+  assert(GCCInstallation.isValid());
 
   // By default, look for the C++ headers in an include directory adjacent to
   // the lib directory of the GCC installation. Note that this is expect to be