[PATCH] D101331: hurd: Detect libstdc++ include paths on Debian Hurd i386

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:3014
                                       llvm::opt::ArgStringList &CC1Args) const {
-  addGCCLibStdCxxIncludePaths(DriverArgs, CC1Args);
+  if (!GCCInstallation.isValid())
+    return;
----------------
sthibaul wrote:
> MaskRay wrote:
> > I'd be glad if we could use `GCCInstallation.isValid()`.
> > 
> > However, @thakis has a chromium usage where `lib/gcc/$triple/crtbegin.o` is not provided while compile-only  libstdc++ search paths are expected.
> > 
> > For now, use `GCCInstallation.isValid() ? GCCInstallation.getTriple().str() : ""`
> Ok, fixed so
Sorry, I noticed that we can just ignore `!GCCInstallation.isValid()`. The chromium usage should still work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101331/new/

https://reviews.llvm.org/D101331