[PATCH] D100667: [clang] Fix assert() crash when checking undeduced arg alignment
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 27 11:03:47 PDT 2021
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks!
================
Comment at: clang/test/SemaCXX/cxx17-undeduced-alignment.cpp:19
+void baz() {
+ // S(123) is undeduced, but when passed to foo() via bar() it is wrapped in
+ // SubstTemplateTypeParm, for which isUndeduced() is false.
----------------
The comment is stale now. Maybe add this test to the existing recovery-expr file `test/SemaCXX/recovery-expr-type.cpp`, as this is a recover-expr related crash (we also need to add the `-std=c++17` flag to the first line of the file, I think it is fine).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100667/new/
https://reviews.llvm.org/D100667
More information about the cfe-commits
mailing list