[PATCH] D101378: [llvm, clang] Remove stdlib includes from .h files without `std::`

Adrian McCarthy via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 27 09:56:31 PDT 2021


amccarth added a comment.

A drive-by look.



================
Comment at: clang/include/clang/Tooling/Transformer/Parsing.h:24
 #include <functional>
-#include <string>
 
----------------
`<functional>` appears unnecessary as well.

And while this doesn't require `<string>` it does require `llvm/ADT/StringRef.h`.


================
Comment at: llvm/include/llvm/DebugInfo/CodeView/GlobalTypeTableBuilder.h:72
   template <typename CreateFunc>
   TypeIndex insertRecordAs(GloballyHashedType Hash, size_t RecordSize,
                            CreateFunc Create) {
----------------
`size_t` may have been coming indirectly from `<memory>`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101378/new/

https://reviews.llvm.org/D101378



More information about the cfe-commits mailing list