[PATCH] D100807: [clang][driver] Use the canonical Darwin arch name when printing out the triple for a Darwin target

Tue Apr 27 08:59:59 PDT 2021

arphaman added a comment.

In D100807#2719561 <https://reviews.llvm.org/D100807#2719561>, @thakis wrote:

> In D100807#2718006 <https://reviews.llvm.org/D100807#2718006>, @arphaman wrote:
>
>> It appears that your bot is running on a Mac with M1 <https://reviews.llvm.org/M1> is that correct? Which OS do you have installed? Thanks
>
> Correct, it's an M1 <https://reviews.llvm.org/M1> Mini. I had to get check-clang and check-llvm to pass on M1 <https://reviews.llvm.org/M1> (PR46647, PR46644) so it looks like nobody else is running this config (why not?). check-builtins is e.g. still failing (PR49918). Kind of on that note, the clang y'all ship with Xcode is > 5% slower than it needs to be due to you apparently building it with profiles collected on an intel machine instead of with profiles collected on an arm machine (data: https://bugs.chromium.org/p/chromium/issues/detail?id=1103322#c34 There's a prebuilt binary at http://commondatastorage.googleapis.com/chromium-browser-clang/Mac_arm64/clang-llvmorg-13-init-7296-ga749bd76-2.tgz with profiles collected on arm that is ~ 12.5% faster than Xcode's clang, see comment 29 on that same crbug).
>
> The bot is running macOS 11.3 IIRC.

We have M1 <https://reviews.llvm.org/M1> CI running internally but it's post commit only right now (that's something we're hoping to change in the future), so this would've been caught in our internal CI. I didn't verify this specific patch on an M1 <https://reviews.llvm.org/M1> myself though, which is something that's probably a good idea to do going forward for driver changes. I didn't know there's another M1 <https://reviews.llvm.org/M1> bot running in the open so I will be mindful of it :)

Thanks for the pointer, I'll take a look the profile data issue, and we will work on rectifying it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100807/new/

https://reviews.llvm.org/D100807