[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

Tue Apr 27 08:15:20 PDT 2021

aeubanks added a comment.

In D100581#2718840 <https://reviews.llvm.org/D100581#2718840>, @uabelho wrote:

> I noticed that with this patch
>  libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp
> fails:
>
>   error: 'warning' diagnostics seen but not expected: 
>     File /repo/uabelho/master-github/libcxx/test/std/strings/basic.string/string.cons/iter_alloc_deduction.fail.cpp Line 51: variable 's' set but not used
>   1 error generated.
>
> (I don't know anything about the testcase I just noticed it failed when trying to uplift my downstream repo.)

looks like this was fixed in 7f98209da6349891b7a74eeadace34d38e7aaadc <https://reviews.llvm.org/rG7f98209da6349891b7a74eeadace34d38e7aaadc>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100581/new/

https://reviews.llvm.org/D100581