[PATCH] D101191: [InstCombine] Fully disable select to and/or i1 folding

Sanjay Patel via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 27 08:07:16 PDT 2021


spatel added inline comments.


================
Comment at: llvm/test/Transforms/PhaseOrdering/X86/vector-reductions.ll:282
 
+; FIXME: this should be vectorized
 define i1 @cmp_lt_gt(double %a, double %b, double %c) {
----------------
I don't think we need to worry about regressing this. It's not ideal before or after, but we probably have a better chance of getting to the goal by making instcombine/simplifycfg correct and consistent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101191/new/

https://reviews.llvm.org/D101191



More information about the cfe-commits mailing list