[PATCH] D100983: [OpenCL] Fix optional image types

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 27 06:37:34 PDT 2021


Anastasia added inline comments.


================
Comment at: clang/include/clang/Basic/OpenCLImageTypes.def:68
 IMAGE_WRITE_TYPE(image2d_array_msaa_depth, OCLImage2dArrayMSAADepth, "cl_khr_gl_msaa_sharing")
-IMAGE_WRITE_TYPE(image3d, OCLImage3d, "cl_khr_3d_image_writes")
+IMAGE_WRITE_TYPE(image3d, OCLImage3d, "")
 
----------------
azabaznov wrote:
> Maybe we should add a test to check that` image3d_t`  is reserved?
Do you mean something like:

```typedef int image3d_t;```

And then check that this gives an error?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100983/new/

https://reviews.llvm.org/D100983



More information about the cfe-commits mailing list