[PATCH] D101168: [C++4OpenCL] Add clang extension for unsafe kernel parameters

Ole Strohm via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 27 03:27:38 PDT 2021


olestrohm added inline comments.


================
Comment at: clang/lib/Sema/SemaDecl.cpp:8651
 static OpenCLParamType getOpenCLKernelParameterType(Sema &S, QualType PT) {
+  if (PT->isDependentType())
+    return InvalidKernelParam;
----------------
Anastasia wrote:
> I would rather add an assert for this because we should not ever reach this function for the dependent types?
The function is actually called on dependent types


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101168/new/

https://reviews.llvm.org/D101168



More information about the cfe-commits mailing list