[PATCH] D100980: [OpenCL] Allow use of double type without extension pragma

Anton Zabaznov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 27 02:40:46 PDT 2021


azabaznov added a comment.

> Anyway since there is not clear benefit that can be found now for the pragma I think we should minimize its use as much as possible.

Unfortunately it's already there :(

> Anyway since there is not clear benefit that can be found now for the pragma I think we should minimize its use as much as possible.

I personally agree, but I believe in order to go forward this patch should introduce diagnostics to commit the introduction of new functionality, I'm not sure what exactly it should be. I'm thinking of some pedantic one such as: "pragma enable is no longer required for type usage". What do you think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100980/new/

https://reviews.llvm.org/D100980



More information about the cfe-commits mailing list