[PATCH] D101327: [Clang][Driver] validate sysregs for -mstack-protector-guard-reg=
Fangrui Song via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 26 20:28:04 PDT 2021
MaskRay added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:1425
+ };
+ return std::find(ValidRegs.begin(), ValidRegs.end(), RegName.upper()) !=
+ ValidRegs.end();
----------------
We should avoid static constructors/destructors if possible. Just use a plain array and `llvm::find(ValidRegs, RegName)`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101327/new/
https://reviews.llvm.org/D101327
More information about the cfe-commits
mailing list