[PATCH] D99439: Update @llvm.powi to handle different int sizes for the exponent

Mon Apr 26 12:23:58 PDT 2021

bjope added inline comments.

================
Comment at: llvm/test/Transforms/InstCombine/pow_fp_int16.ll:1
-; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
-; RUN: opt -mtriple unknown -instcombine -S < %s | FileCheck %s
+; RUN: opt -mtriple msp430 -instcombine -S < %s | FileCheck %s

----------------
bjope wrote:
> fhahn wrote:
> > I don't think we can rely on any specific triple here. If a triple is needed it should be in a sub-directory.
> Yes, right, I need to move this.
A bit surprised that there are several tests in `test/Transform/InstCombine/` that use `-mtriple` without the test case being in a target specific subfolder. For example  `test/Transform/InstCombine/pow-1.ll` is verifying 12 different mtriple variants (plus the default). Is that OK? How could one know if a target specific dir is needed when using `-mtriple` (unless doing some experiments with different targets-to-build settings)?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99439/new/

https://reviews.llvm.org/D99439