[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

Mon Apr 26 10:49:32 PDT 2021

amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.

There's a lot going on here, but I don't see anything wrong.  Thanks for the completeness of the tests and the comments, as that helps a lot in understanding what's going on here.

================
Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:295
+                 .Case(".o", Coff)
+                 .Default(Unknown);
+  if (F != Unknown)
----------------
".obj"?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100756/new/

https://reviews.llvm.org/D100756