[PATCH] D100739: [Coroutines] Handle overaligned frame allocation (2)
    Yuanfang Chen via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Mon Apr 26 10:23:57 PDT 2021
    
    
  
ychen added a comment.
In D100739#2717227 <https://reviews.llvm.org/D100739#2717227>, @rjmccall wrote:
> Yes, if you can dynamically choose to use an aligned allocator, that's clearly just much better.
Right now:
Intrinsic::coro_size_aligned :   overaligned frame: over-allocate, adjust start address;    non-overaligned frame: no-op
Intrinsic::coro_size :                overaligned frame: no-op;                                                 non-overaligned frame: no-op
Do you mean to remove `Intrinsic::coro_size_aligned` and make 
Intrinsic::coro_size :                overaligned frame: over-allocate, adjust start address;    non-overaligned frame: no-op
that makes sense to me. Just want to confirm first.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100739/new/
https://reviews.llvm.org/D100739
    
    
More information about the cfe-commits
mailing list