[PATCH] D100772: [ARM] Neon Polynomial vadd Intrinsic fix

[Ryan Santhirarajan via Phabricator via cfe-commits]

rsanthir.quic marked an inline comment as done.
rsanthir.quic added inline comments.


================
Comment at: clang/include/clang/Basic/arm_neon.td:712
+////////////////////////////////////////////////////////////////////////////////
+// Crypto
+// TODO: poly128_t not implemented on aarch32
----------------
DavidSpickett wrote:
> This isn't a crypto intrinsic, it just happens to be right after a block like:
> ```
> let ArchGuard = "__ARM_ARCH >= 8 && defined(__ARM_FEATURE_CRYPTO)" in {
> <...>
> def SM4EKEY : SInst<"vsm4ekey", "...", "QUi">;
> }
> ```
> 
> You could instead say:
> ```
> // Non poly128_t vaddp for Arm and AArch64
> ```
> (keep the todo)
I agree that it isn't strictly crypto, I think it is used primarily for cryptographic applications. I'll apply your suggestion


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100772/new/

https://reviews.llvm.org/D100772