[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

[Denys Petrov via Phabricator via cfe-commits]

ASDenysPetrov added a comment.

@vsavchenko 
I make some tests and fixes. Please, consider.



================
Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:458
   }
   if (event.key == "S") {
     var checked = document.getElementsByName("showCounterexample")[0].checked;
----------------
vsavchenko wrote:
> ASDenysPetrov wrote:
> > Seems like this shortcut works only with the capital **S** aka //shift+s//
> > Should we support any **s** state?
> As far as I understand, that matches the original intention because the help message mentions exactly "Shift+S"
> {F15355624}
I've checked again.
When CapsLock is ON, `shift+s` has no effect, but single `s` has. The same vice versa.
The real issue is that we check for **capital s** instead of **shift+s**.
This change will handle it correctly. I've checked it on IE and Chrome. It works for me.


================
Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:1275-1278
+    left: relative.left + window.scrollX,
+    right: relative.right + window.scrollX,
+    top: relative.top + window.scrollY,
+    bottom: relative.bottom + window.scrollY,
----------------
This is the root cause of why I wasn't able to see arrows in IE11.
I found and checked a fix. It works on IE and Chrome. Thanks to https://github.com/imgix/drift/issues/33#issue-165784939



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92639/new/

https://reviews.llvm.org/D92639