[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

Mon Apr 26 06:31:26 PDT 2021

Anastasia added a comment.

We have discussed testing of headers within OpenCL developer community and wider:
https://lists.llvm.org/pipermail/cfe-dev/2021-April/068040.html

and the conclusions I have drawn are as follows:

- There seem to be no big interest in improving upstream testing of `opencl-c.h` and therefore improving the quality assurance processes in upstream development.
- There is no plan for `opencl-c.h` to be exposed to the end user in upstream. An alternative newer solution using Tablegen is currently enabled by default through the clang driver as a primary header.
- It is likely that `opencl-c.h` will be deprecated or even removed in the future releases however this discussion hasn't fully taken place yet.

Considering the above and the fact that the `opencl-c.h` header will continue to exist for the time being as it has been adopted by various out-of-tree implementations of OpenCL it would be reasonable to continue with this patch as it extends in a straightforward way existing functionality with the same experimental quality.

I would quite like to find one extra reviewer from a different vendor preferably with OpenCL 3 expertise.  @azabaznov would you be happy to review this?

I would also like to recommend using an experimental test (https://reviews.llvm.org/D97869) that is planned for the Tablegen header solution before committing this patch to gain more confidence. However, It might be good to check with @svenvh  first to see whether there are any know issues for running such test with `opencl-c.h`.

I would also like to loop @yaxunl  in for the extra pair of eyes wrt prior to OpenCL 3 functionality.

Ideally, it would be good if we don't commit it too close to the release branch i.e. good to leave a few weeks for the bugs to be discovered and fixed considering the possible propagation time to the external projects.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92004/new/

https://reviews.llvm.org/D92004