[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

Mon Apr 26 05:51:07 PDT 2021

jankratochvil planned changes to this revision.
jankratochvil added a comment.

In D101236#2716286 <https://reviews.llvm.org/D101236#2716286>, @teemperor wrote:

> Not sure what the backtrace is for the `clang::FieldDecl::isZeroSize` crash but what might relevant:

That happens only with half of the patch: https://people.redhat.com/jkratoch/lldb-iszerosize.patch
And only for these testcases:

  lldb-api :: commands/expression/codegen-crash-typedefdecl-not-in_declcontext/TestCodegenCrashTypedefDeclNotInDeclContext.py
  lldb-api :: commands/expression/completion-crash-incomplete-record/TestCompletionCrashIncompleteRecord.py
  lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx/map/TestDataFormatterLibccMap.py

The backtrace is: https://people.redhat.com/jkratoch/lldb-iszerosize.txt

> IMHO this is fine as a temporary solution until we finally fix the LLDB Decl completion.

Great, thanks.

In D101236#2716317 <https://reviews.llvm.org/D101236#2716317>, @martong wrote:

> You can create a similar descendant class, but with the MinimalImport flag set to true. Then you could call `ImportDefinition` subsequently after an `Import` call. Perhaps that could trigger your assertion.

I have been looking for such suggestion, thanks. I will try that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101236/new/

https://reviews.llvm.org/D101236