[PATCH] D101087: [OpenCL] Introduce new method for validating OpenCL target

Mon Apr 26 04:52:29 PDT 2021

Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.

LGTM! Thanks.

I have made a minor suggestion to testing that could be addressed in the final commit.

================
Comment at: clang/test/Misc/nvptx.unsupported_core.cl:1
+// RUN: %clang_cc1 -cl-std=CL2.0 -triple nvptx-unknown-unknown -Wpedantic-core-features %s 2> %t
+// RUN: FileCheck < %t %s
----------------
We could add a line with `-cl-std=CLC++` to check the full wording of the new diagnostic.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101087/new/

https://reviews.llvm.org/D101087