[PATCH] D100741: [clangd] Rename HeuristicResolver::resolveCallExpr() to resolveReturnTypeOfCallExpr()

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 23 13:33:10 PDT 2021


sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: cfe-commits.

Agree this is confusing, thanks for fixing!



================
Comment at: clang-tools-extra/clangd/HeuristicResolver.h:57
+  std::vector<const NamedDecl *>
+  resolveReturnTypeOfCallExpr(const CallExpr *CE) const;
   std::vector<const NamedDecl *>
----------------
nit: I think `resolveTypeOfCallExpr` (or `resolveCallExprType`) is sufficient/better, as technically it's the callee that has a return type, the call expr just has a type


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100741/new/

https://reviews.llvm.org/D100741



More information about the cfe-commits mailing list